Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛] Broken interstitials #16

Closed
dylancom opened this issue Dec 5, 2021 · 1 comment
Closed

[🐛] Broken interstitials #16

dylancom opened this issue Dec 5, 2021 · 1 comment

Comments

@dylancom
Copy link
Collaborator

dylancom commented Dec 5, 2021

undefined is not an object (evaluating 'module.app.name') pops up when trying to use interstitials (and probably rewarded ads).

I think this is related to how the default export is now the GoogleAdsModule directly, which used to be a function call to createNameSpace(args), containing all the native module names etc.

Original: https://github.com/invertase/react-native-firebase/blob/v11.5.0/packages/admob/lib/index.js#L79
Now: https://github.com/invertase/react-native-google-ads/blob/main/lib/index.js#L50

@dylancom dylancom added the help wanted Extra attention is needed label Dec 5, 2021
@mikehardy
Copy link
Collaborator

Probably yes - this one is a little tricky
react-native-firebase is a monorepo with multiple native modules in different packages and some in the same package, and includes module loading infrastructure for all of them.
Not a monorepo here but still multiple native modules, and I intended to port the module loading infrastructure over (and genericize it a bit, because we need the same for MLKit which is also on the "extracted to new repository, not working yet" project list)

Clearly something not working right in the multiple-native-module-loading infra then - this stuff is pretty subtle unfortunately and I don't work with it much, so when I do have to go in there I basically light the whole thing up with println debugging and just slowly trace through for a fix. A bit tedious but at least once it works it really works

@dylancom dylancom closed this as completed Dec 7, 2021
@mikehardy mikehardy removed the help wanted Extra attention is needed label Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants