Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace banner v7 methods with v8 methods #37

Merged
merged 1 commit into from
Dec 12, 2021

Conversation

dylancom
Copy link
Collaborator

Description

  • Banner methods were renamed in v8.
  • adViewWillLeaveApplication was removed.

@docs-page
Copy link

docs-page bot commented Dec 12, 2021

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/react-native-google-ads~37

Documentation is deployed and generated using docs.page.

@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #37 (2b84b07) into main (638c63f) will not change coverage.
The diff coverage is n/a.

❗ Current head 2b84b07 differs from pull request most recent head 2afd118. Consider uploading reports for the commit 2afd118 to get more accurate results

@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   19.70%   19.70%           
=======================================
  Files          21       21           
  Lines         665      665           
  Branches      167      167           
=======================================
  Hits          131      131           
  Misses        415      415           
  Partials      119      119           

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a clean fix thanks!

@mikehardy mikehardy added the workflow: pending merge Waiting on CI or question responses to merge, but otherwise ready label Dec 12, 2021
@mikehardy mikehardy merged commit c53c657 into invertase:main Dec 12, 2021
@mikehardy mikehardy removed the workflow: pending merge Waiting on CI or question responses to merge, but otherwise ready label Dec 12, 2021
github-actions bot pushed a commit that referenced this pull request Dec 13, 2021
## [3.1.0](v3.0.0...v3.1.0) (2021-12-13)

### Features

* **ios, banner:** replace v7 methods with v8 methods ([#37](#37)) ([c53c657](c53c657))
@mikehardy
Copy link
Collaborator

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Star-dev325 added a commit to Star-dev325/react-native-google-mobile-ads that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants