-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rewarded ads crash & request configuration #31
fix: rewarded ads crash & request configuration #31
Conversation
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/react-native-google-ads~31 Documentation is deployed and generated using docs.page. |
No good deed unpunished ;-)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it just needs a change to the jest to conform to older style admob()
Codecov Report
@@ Coverage Diff @@
## main #31 +/- ##
==========================================
+ Coverage 19.00% 19.70% +0.71%
==========================================
Files 21 21
Lines 658 665 +7
Branches 165 167 +2
==========================================
+ Hits 125 131 +6
- Misses 414 415 +1
Partials 119 119 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a thing of beauty
## [2.0.1](v2.0.0...v2.0.1) (2021-12-12) ### Bug Fixes * rewarded ads crash & request configuration ([#31](#31)) ([382f146](382f146))
🎉 This PR is included in version 2.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [2.0.1](invertase/react-native-google-mobile-ads@v2.0.0...v2.0.1) (2021-12-12) ### Bug Fixes * rewarded ads crash & request configuration ([#31](invertase/react-native-google-mobile-ads#31)) ([382f146](invertase/react-native-google-mobile-ads@382f146))
Description
Fixes #3, Fixes #5
Also makes sure that the default export aligns with the docs and previous rnfb implementation. (Calling admob().setConfiguration() instead of admob.setConfiguration())