Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rewarded ads crash & request configuration #31

Merged

Conversation

dylancom
Copy link
Collaborator

@dylancom dylancom commented Dec 11, 2021

Description

Fixes #3, Fixes #5

Also makes sure that the default export aligns with the docs and previous rnfb implementation. (Calling admob().setConfiguration() instead of admob.setConfiguration())

@docs-page
Copy link

docs-page bot commented Dec 11, 2021

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/react-native-google-ads~31

Documentation is deployed and generated using docs.page.

@mikehardy
Copy link
Collaborator

No good deed unpunished ;-)


FAIL __tests__/googleAds.test.ts
  ● Test suite failed to run

    __tests__/googleAds.test.ts:15:17 - error TS2339: Property 'setRequestConfiguration' does not exist on type '() => Module & Statics'.

    15           admob.setRequestConfiguration({
                       ~~~~~~~~~~~~~~~~~~~~~~~
    __tests__/googleAds.test.ts:28:17 - error TS2339: Property 'setRequestConfiguration' does not exist on type '() => Module & Statics'.

    28           admob.setRequestConfiguration({
                       ~~~~~~~~~~~~~~~~~~~~~~~
    __tests__/googleAds.test.ts:41:17 - error TS2339: Property 'setRequestConfiguration' does not exist on type '() => Module & Statics'.

    41           admob.setRequestConfiguration({
                       ~~~~~~~~~~~~~~~~~~~~~~~

PASS __tests__/interstitial.test.ts
PASS __tests__/consent.test.ts

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it just needs a change to the jest to conform to older style admob()

@mikehardy mikehardy added workflow: pending merge Waiting on CI or question responses to merge, but otherwise ready workflow: waiting for feedback Waiting on response to questions labels Dec 11, 2021
@codecov
Copy link

codecov bot commented Dec 11, 2021

Codecov Report

Merging #31 (a4a05df) into main (bac264d) will increase coverage by 0.71%.
The diff coverage is 77.78%.

❗ Current head a4a05df differs from pull request most recent head a1c5480. Consider uploading reports for the commit a1c5480 to get more accurate results

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   19.00%   19.70%   +0.71%     
==========================================
  Files          21       21              
  Lines         658      665       +7     
  Branches      165      167       +2     
==========================================
+ Hits          125      131       +6     
- Misses        414      415       +1     
  Partials      119      119              

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a thing of beauty

@mikehardy mikehardy merged commit 382f146 into invertase:main Dec 11, 2021
@mikehardy mikehardy removed workflow: waiting for feedback Waiting on response to questions workflow: pending merge Waiting on CI or question responses to merge, but otherwise ready labels Dec 11, 2021
github-actions bot pushed a commit that referenced this pull request Dec 12, 2021
## [2.0.1](v2.0.0...v2.0.1) (2021-12-12)

### Bug Fixes

* rewarded ads crash & request configuration ([#31](#31)) ([382f146](382f146))
@mikehardy
Copy link
Collaborator

🎉 This PR is included in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Star-dev325 added a commit to Star-dev325/react-native-google-mobile-ads that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AdMob initialization with admob.setRequestConfiguration not working correctly Rewarded value can be nil
2 participants