-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ios)!: Google Mobile Ads SDK 8 w/new testDeviceIdentifiers vs testDevices #30
feat(ios)!: Google Mobile Ads SDK 8 w/new testDeviceIdentifiers vs testDevices #30
Conversation
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/react-native-google-ads~30 Documentation is deployed and generated using docs.page. |
Codecov Report
@@ Coverage Diff @@
## main #30 +/- ##
=======================================
Coverage 19.00% 19.00%
=======================================
Files 21 21
Lines 658 658
Branches 165 165
=======================================
Hits 125 125
Misses 414 414
Partials 119 119 |
a02b119
to
6e57a20
Compare
@dylancom |
holdover from living in a monorepo where it was in a loop...
I hopefully fixed release automation's final step with a new token. PR title changed to signify breaking status ( |
# [2.0.0](v1.0.2...v2.0.0) (2021-12-11) * feat(ios)!: Google Mobile Ads SDK 8 w/new testDeviceIdentifiers vs testDevices (#30) ([bac264d](bac264d)), closes [#30](#30) ### BREAKING CHANGES * "testDevices" property no longer exists. You must use "testDeviceIdentifiers". The testDeviceIdentifiers property applies to all ad requests, while the old testDevices property was set per-request.
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Yep, new github PAT did the trick. We are 100% automated now. Just missing on-device tests and the slow battle to get coverage back up. It'll get there. Thanks so much for getting this package going, it means a lot - it was really weighing on me as RNFB maintainer, having made some promises to get it going and then not having the time. Big weight off my shoulders. Cheers |
# [2.0.0](invertase/react-native-google-mobile-ads@v1.0.2...v2.0.0) (2021-12-11) * feat(ios)!: Google Mobile Ads SDK 8 w/new testDeviceIdentifiers vs testDevices (#30) ([bac264d](invertase/react-native-google-mobile-ads@bac264d)), closes [#30](invertase/react-native-google-mobile-ads#30) ### BREAKING CHANGES * "testDevices" property no longer exists. You must use "testDeviceIdentifiers". The testDeviceIdentifiers property applies to all ad requests, while the old testDevices property was set per-request.
Changes
The willLeaveApplication callback for all ad formats has been removed in favor of the applicationDidEnterBackground: and sceneDidEnterBackground: methods. Using OS-level APIs notify you whenever users leave your app, regardless of whether or not it is due to an ad interaction.
Note that the willLeaveApplication callback was never intended to be an ad click handler, and relying on this callback to report clicks did not produce an accurate metric. For example, a click on the AdChoices icon that launched an external browser invoked the callback but did not count a click.