Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios)!: Google Mobile Ads SDK 8 w/new testDeviceIdentifiers vs testDevices #30

Merged
merged 8 commits into from
Dec 11, 2021

Conversation

dylancom
Copy link
Collaborator

@dylancom dylancom commented Dec 10, 2021

Changes

  • testDevices became testDeviceIdentifiers and have to be set in the Admob request configuration instead of per ad.
  • Smart banner deprecation in favor of adaptive banner.
  • Leave application callback removal
    The willLeaveApplication callback for all ad formats has been removed in favor of the applicationDidEnterBackground: and sceneDidEnterBackground: methods. Using OS-level APIs notify you whenever users leave your app, regardless of whether or not it is due to an ad interaction.
    Note that the willLeaveApplication callback was never intended to be an ad click handler, and relying on this callback to report clicks did not produce an accurate metric. For example, a click on the AdChoices icon that launched an external browser invoked the callback but did not count a click.

@docs-page
Copy link

docs-page bot commented Dec 10, 2021

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/react-native-google-ads~30

Documentation is deployed and generated using docs.page.

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #30 (4e2fe93) into main (1a694ae) will not change coverage.
The diff coverage is n/a.

❗ Current head 4e2fe93 differs from pull request most recent head 60fbb30. Consider uploading reports for the commit 60fbb30 to get more accurate results

@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage   19.00%   19.00%           
=======================================
  Files          21       21           
  Lines         658      658           
  Branches      165      165           
=======================================
  Hits          125      125           
  Misses        414      414           
  Partials      119      119           

@dylancom dylancom changed the title [WIP] Google Mobile Ads SDK 8 (iOS) refactor: Google Mobile Ads SDK 8 (iOS) Dec 10, 2021
@dylancom dylancom changed the title refactor: Google Mobile Ads SDK 8 (iOS) upgrade: Google Mobile Ads SDK 8 (iOS) Dec 10, 2021
@dylancom dylancom changed the title upgrade: Google Mobile Ads SDK 8 (iOS) refactor: Google Mobile Ads SDK 8 (iOS) Dec 10, 2021
@mikehardy mikehardy force-pushed the upgrade/google-mobile-ads-sdk branch from a02b119 to 6e57a20 Compare December 10, 2021 23:51
@mikehardy
Copy link
Collaborator

mikehardy commented Dec 10, 2021

@dylancom ⚠️ ⚠️ I rebased you from main and then pushed, I think I fixed the patch-package script, and I ran yarn lint:ios:fix - with those I think this will actually be good to merge and CI will be all green + patches 🤞
I know it's Friday night late there, I hope this wasn't too bold, I couldn't imagine you were still hacking on it? I'm about to be off for the night myself. Cheers

holdover from living in a monorepo where it was in a loop...
@mikehardy
Copy link
Collaborator

@mikehardy mikehardy changed the title refactor: Google Mobile Ads SDK 8 (iOS) feat(ios)!: Google Mobile Ads SDK 8 w/new testDeviceIdentifiers vs testDevices Dec 11, 2021
@mikehardy mikehardy added the workflow: pending merge Waiting on CI or question responses to merge, but otherwise ready label Dec 11, 2021
@mikehardy
Copy link
Collaborator

I hopefully fixed release automation's final step with a new token. PR title changed to signify breaking status (! w/brief explanation). All queued up on the runway ready to lift off

@mikehardy mikehardy merged commit bac264d into invertase:main Dec 11, 2021
github-actions bot pushed a commit that referenced this pull request Dec 11, 2021
# [2.0.0](v1.0.2...v2.0.0) (2021-12-11)

* feat(ios)!: Google Mobile Ads SDK 8 w/new testDeviceIdentifiers vs testDevices (#30) ([bac264d](bac264d)), closes [#30](#30)

### BREAKING CHANGES

* "testDevices" property no longer exists. You must use "testDeviceIdentifiers". The testDeviceIdentifiers property applies to all ad requests, while the old testDevices property was set per-request.
@mikehardy
Copy link
Collaborator

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mikehardy mikehardy added released and removed workflow: pending merge Waiting on CI or question responses to merge, but otherwise ready labels Dec 11, 2021
@mikehardy
Copy link
Collaborator

Yep, new github PAT did the trick. We are 100% automated now. Just missing on-device tests and the slow battle to get coverage back up. It'll get there. Thanks so much for getting this package going, it means a lot - it was really weighing on me as RNFB maintainer, having made some promises to get it going and then not having the time. Big weight off my shoulders. Cheers

Star-dev325 added a commit to Star-dev325/react-native-google-mobile-ads that referenced this pull request Jun 7, 2024
# [2.0.0](invertase/react-native-google-mobile-ads@v1.0.2...v2.0.0) (2021-12-11)

* feat(ios)!: Google Mobile Ads SDK 8 w/new testDeviceIdentifiers vs testDevices (#30) ([bac264d](invertase/react-native-google-mobile-ads@bac264d)), closes [#30](invertase/react-native-google-mobile-ads#30)

### BREAKING CHANGES

* "testDevices" property no longer exists. You must use "testDeviceIdentifiers". The testDeviceIdentifiers property applies to all ad requests, while the old testDevices property was set per-request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants