fix: displaying banner ads, wrong config in docs #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/react-native-google-ads~14 Documentation is deployed and generated using docs.page. |
Codecov Report
@@ Coverage Diff @@
## main #14 +/- ##
=======================================
Coverage 18.95% 18.95%
=======================================
Files 21 21
Lines 644 644
Branches 156 156
=======================================
Hits 122 122
Misses 405 405
Partials 117 117 |
mikehardy
approved these changes
Dec 5, 2021
|
Ha just realized you only posted this 4 minutes ago. I need to be async again today but you just happened to post this while I was doing my morning coffee + github notification scan ;-) |
|
Haha, amazing timing! |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 8, 2021
# 1.0.0 (2021-12-08) ### Bug Fixes * android app id from app.json works, example has detox integrated and working in android ([24f83b2](24f83b2)) * **android:** use correct module name for banner ads ([#17](#17)) ([7c7c8b5](7c7c8b5)) * displaying banner ads, config in docs ([#14](#14)) ([21e4f42](21e4f42)) * incorrect module naming ([#10](#10)) ([79f86b9](79f86b9)) * interstitials and rewarded ads ([#18](#18)) ([9569b98](9569b98)) * **ios:** add ios config scripts missed in previous commit ([227ca7c](227ca7c)) * **ios:** ios app.json --> Info.plist auto-config works now ([6c1f4d4](6c1f4d4)) * **ios:** missing dollar signs in podspec version override ([#8](#8)) ([5984288](5984288)) * **release:** remove npm config and git config as well ([8139e88](8139e88)) * **release:** semantic release does not need the ssh key agent config ([930bc03](930bc03)) * remove incorrect git branch ref in publish workflow, clean changelog ([aec5b84](aec5b84)) * **test:** link to jet package via named branch vs commit hash ([#7](#7)) ([151f6aa](151f6aa)) ### Features * example test in new test harness works ([2041fa2](2041fa2)) * **native:** native code extraction is complete and passes static type check ([02c2af6](02c2af6))
Star-dev325
added a commit
to Star-dev325/react-native-google-mobile-ads
that referenced
this pull request
Jun 7, 2024
# 1.0.0 (2021-12-08) ### Bug Fixes * android app id from app.json works, example has detox integrated and working in android ([24f83b2](invertase/react-native-google-mobile-ads@24f83b2)) * **android:** use correct module name for banner ads ([#17](invertase/react-native-google-mobile-ads#17)) ([7c7c8b5](invertase/react-native-google-mobile-ads@7c7c8b5)) * displaying banner ads, config in docs ([#14](invertase/react-native-google-mobile-ads#14)) ([21e4f42](invertase/react-native-google-mobile-ads@21e4f42)) * incorrect module naming ([#10](invertase/react-native-google-mobile-ads#10)) ([79f86b9](invertase/react-native-google-mobile-ads@79f86b9)) * interstitials and rewarded ads ([#18](invertase/react-native-google-mobile-ads#18)) ([9569b98](invertase/react-native-google-mobile-ads@9569b98)) * **ios:** add ios config scripts missed in previous commit ([227ca7c](invertase/react-native-google-mobile-ads@227ca7c)) * **ios:** ios app.json --> Info.plist auto-config works now ([6c1f4d4](invertase/react-native-google-mobile-ads@6c1f4d4)) * **ios:** missing dollar signs in podspec version override ([#8](invertase/react-native-google-mobile-ads#8)) ([5984288](invertase/react-native-google-mobile-ads@5984288)) * **release:** remove npm config and git config as well ([8139e88](invertase/react-native-google-mobile-ads@8139e88)) * **release:** semantic release does not need the ssh key agent config ([930bc03](invertase/react-native-google-mobile-ads@930bc03)) * remove incorrect git branch ref in publish workflow, clean changelog ([aec5b84](invertase/react-native-google-mobile-ads@aec5b84)) * **test:** link to jet package via named branch vs commit hash ([#7](invertase/react-native-google-mobile-ads#7)) ([151f6aa](invertase/react-native-google-mobile-ads@151f6aa)) ### Features * example test in new test harness works ([2041fa2](invertase/react-native-google-mobile-ads@2041fa2)) * **native:** native code extraction is complete and passes static type check ([02c2af6](invertase/react-native-google-mobile-ads@02c2af6))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I just initialized a new RN project, followed the docs and noticed the app would crash at first.
The crash was because the google ads sdk couldn't find the app_id from the app.json config.
Therefore I updated the docs.
Then I noticed banners would still not render, one more name change was required (which I think I forgot to push in my previous PR's).