fix(auth): use correct app instance (vs always default) in multifactor and phone auth

[Somebodybro]

Description

There is was/is a bug in the firebase sdk(12th of january 2024) that prevents multifactor login from being completed with a secondary app instance, but after that is updated, secondary instances should work with mfa

Related issues

• Related issue upstream: #12265
• Fixes Multiple firebase projects with multi factor authentication #7339

Release Summary

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Yes
• My change supports the following platforms;
  • Android
  • iOS
• My change includes tests;
  • e2e tests added or updated in packages/\*\*/e2e
  • jest tests added or updated in packages/\*\*/__tests__
• I have updated TypeScript types that are affected by my change.
• This is a breaking change;
  • Yes
  • No

Test Plan

---

Think react-native-firebase is great? Please consider supporting the project with any of the below:

• 👉 Star this repo on GitHub ⭐️
• 👉 Follow React Native Firebase and Invertase on Twitter

🔥

[CLAassistant]

All committers have signed the CLA.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-native-firebase	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 25, 2024 6:02am
react-native-firebase-next	❌ Failed (Inspect)			Jan 25, 2024 6:02am

[mikehardy]

Hey @Somebodybro 👋 - thanks for working through this both here and upstream! Well done

Upstream note: the PR you proposed to firebase-ios-sdk was merged and it was just tagged for firebase-ios-sdk 10.21.0 so hopefully that's out soon, but it is not out yet as I type this

I control the sdk versions via separate PRs, but I don't think we need to wait on this? It's still correct here I think, it just won't completely work until upstream 10.21.0 is out?

The only thing remaining here is for you to run lint:ios:fix and commit the results - I did that locally but I can't push the result out as your repo main branch rejects the push, so you'll have to do it yourself I think?

[Somebodybro]

Hei! I ran lint:ios:fix and the repo should be linted.
Can't believe I completely forgot to do that.

Sorry I was not working on this for a couple of days. It was nice working with this library (and upstream).

[mikehardy]

fantastic