-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Check Replay Protection #7394
Comments
Interesting - I haven't contemplated adding support for it, but I would happily merge any reasonable PR that implemented the API and wrapped the underlying native calls This is the API to model, as we use the firebase-js-sdk API shapes: https://firebase.google.com/docs/app-check/web/custom-resource#replay-protection |
@mikehardy Just submitted a PR. Would be great if you could have a look :) |
Hello 👋, to help manage issues we automatically close stale issues. This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?
Thank you for your contributions. |
Not stale and neither is the PR - definitely going to happen - sorry for the delay - thank you for your patience |
(This is on the latest version 18.7.3, 18.6.1 seems to work okay) |
Hmm, I was able to get it up & running on the latest version. It might be worth opening a new issue with more details of your setup |
@JasonPan You have most likely overridden your firebase-ios-sdk version, which is something we intend to clearly note is at your own risk as we will adopt new features that require new versions of the SDK from time to time. If you override your SDK and are not using the correct minimum version of firebase-ios-sdk as we direct in our app module package.json, you will see compilation errors like this They are an indicator that you should take your firebase-ios-sdk version override out of your Podfile (preferred) or you must bump your firebase pod versions |
The feature has been merged though, and there's no further work planned. It appears to be working as intended. |
Nevermind, thanks! You're right, I did just have to make sure all my RN Firebase dependencies were upgraded to the latest version, working now :) |
For my reference, did this issue also tackle implementing replay protection for Firebase Cloud Function calls? e.g. using |
@JasonPan it is not easy to use, by my read, and the use case is specific to non-firebase resources yes - I think the firebase docs are pretty reasonable on how to use it though https://firebase.google.com/docs/app-check/web/custom-resource#replay-protection - you don't "set" the token, you send the limited use token to your non-firebase endpoint, and when that code goes to verify that the token is valid, it can also check if it's already been used, to guard against token reuse / replay If I understand correctly |
Hi!
Would it be possible to use the app-check replay protection with this library?
The text was updated successfully, but these errors were encountered: