Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage, android): honor android_bypass_emulator_url_remap flag #7326

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

PedroDuarte536
Copy link
Contributor

Description

The android_bypass_emulator_url_remap flag is not being validated on the storage package. It works as expected on the packages for functions and authentication but this one in specific remaps the hosts anyway.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

The code added was copied from the working code on the functions packasge.

Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Sep 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2023 3:12am
react-native-firebase-next ❌ Failed (Inspect) Sep 4, 2023 3:12am

@CLAassistant
Copy link

CLAassistant commented Sep 3, 2023

CLA assistant check
All committers have signed the CLA.

@mikehardy mikehardy changed the title fix(storage,android): Emulators remapping hostnames even with the android_bypass_emulator_url_remap flag fix(storage, android): Honor android_bypass_emulator_url_remap flag Sep 3, 2023
@mikehardy mikehardy changed the title fix(storage, android): Honor android_bypass_emulator_url_remap flag fix(storage, android): honor android_bypass_emulator_url_remap flag Sep 3, 2023
mikehardy
mikehardy previously approved these changes Sep 3, 2023
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh - that is an unfortunate oversight! Sorry about that.
Thanks a bunch for taking the time to post a fix, it looks correct

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Sep 3, 2023
@mikehardy
Copy link
Collaborator

@PedroDuarte536 could you follow the link on either the CLA comment or on the "Details" link for the CLA signing check failure? We need the CLA signed in order to merge code from contributors 🙏

@PedroDuarte536
Copy link
Contributor Author

No problem @mikehardy! Should be done already, thank you for the help!

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLA signed - I pushed a tiny commit to fix the lint error CI flagged, should go green then can merge 🤞 - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants