-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(storage, android): honor android_bypass_emulator_url_remap flag #7326
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh - that is an unfortunate oversight! Sorry about that.
Thanks a bunch for taking the time to post a fix, it looks correct
@PedroDuarte536 could you follow the link on either the CLA comment or on the "Details" link for the CLA signing check failure? We need the CLA signed in order to merge code from contributors 🙏 |
No problem @mikehardy! Should be done already, thank you for the help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLA signed - I pushed a tiny commit to fix the lint error CI flagged, should go green then can merge 🤞 - thanks!
Description
The android_bypass_emulator_url_remap flag is not being validated on the storage package. It works as expected on the packages for functions and authentication but this one in specific remaps the hosts anyway.
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
The code added was copied from the working code on the functions packasge.
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter