-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth, ios): Add support for Facebook Limited Login #6073
Conversation
This pull request is being automatically deployed with Vercel (learn more). react-native-firebase – ./🔍 Inspect: https://vercel.com/invertase/react-native-firebase/6n4jz3FjC2nrWh9C7TddngfnDjUJ react-native-firebase-next – ./website_modular🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/7zRJTWvkAMA1iHm2dJd8Aua6bKB7 [Deployment for a3a1abb canceled] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this looks great, thank you for the PR! Hopefully CI goes green, frequently there is some trivial lint thing but I don't see anything with the naked eye right now...
Codecov Report
@@ Coverage Diff @@
## main #6073 +/- ##
=========================================
Coverage 52.92% 52.92%
Complexity 622 622
=========================================
Files 208 208
Lines 10220 10220
Branches 1625 1626 +1
=========================================
Hits 5408 5408
Misses 4558 4558
Partials 254 254 |
Add support for Facebook Limited Login by making passing a second argument to the providers `credential` function optional and handling this later on in the native code by calling the OAuth provider for Facebook. Fixes: #5441 Signed-off-by: Martin Mazein <[email protected]>
This is just simply testing if the nonce passed to credentials is the nonce we see in the providers credential object. Signed-off-by: Martin Mazein <[email protected]>
Signed-off-by: Martin Mazein <[email protected]>
Fixed format errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at a computer now (was mobile prior) and still looks good to me. I approved the second CI run, hopefully goes green this time ;-)
Description
Add support for Facebook Limited Login, as well as some testing and documentation around that feature.
Related issues
Fixes #5441.
Release Summary
Add support for Facebook Limited Login.
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Using this patchset in one of my own apps, login into Facebook w/ and w/o limited login is still functional:
🔥