-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth, android): add android for disable app verification feature #6069
feat(auth, android): add android for disable app verification feature #6069
Conversation
This pull request is being automatically deployed with Vercel (learn more). react-native-firebase-next – ./website_modular🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/5zAQrdo2uSU9FSHYEpFtc3zVuF41 [Deployment for de4d89b canceled] react-native-firebase – ./🔍 Inspect: https://vercel.com/invertase/react-native-firebase/BqGMEJF4c8tZSLs63jWaYcbXig18 |
c032a61
to
a2a4105
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh that looks really clean! Thanks for posting this. Approving the CI runs here, hopefully it goes right through, if not I'll work with you to get all the various CI checks cleared.
Codecov Report
@@ Coverage Diff @@
## main #6069 +/- ##
============================================
- Coverage 53.37% 52.92% -0.45%
+ Complexity 632 622 -10
============================================
Files 208 208
Lines 10214 10220 +6
Branches 1626 1625 -1
============================================
- Hits 5451 5408 -43
- Misses 4489 4558 +69
+ Partials 274 254 -20 |
This one makes sense - now that auth is no longer ios-only for the method, the import itself (at top of file) is no longer needed Don't worry about tacking on little follow-on commits, squash-merging this one is fine since it's a focused change even with follow-ons and it'll leave a clean commit trail post-merge once squashed |
I reached into the source tree for the PR and just removed the |
Publishing it now, new version will be out on npmjs.com in a minute - thanks again |
Thanks for the lint fix and the fast processing of the PR 😄 |
Description
At the moment it is only possible to disable the app verification on the iOS platform for testing.
As I wanted to create e2e tests for the android version of my app, I created the necessary code changes to make this flag also possible on the Android platform. 😄
Related issues
No related Issue as far as I now.
Release Summary
auth: appVerificationDisabledForTesting now also settable for Android platform
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
🔥