Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛] Functions SDK Inconsistency #4919

Closed
mbleigh opened this issue Feb 16, 2021 · 1 comment · Fixed by #4950
Closed

[🐛] Functions SDK Inconsistency #4919

mbleigh opened this issue Feb 16, 2021 · 1 comment · Fixed by #4950
Labels
impact: web-implementation An API in RNFB does not conform to the Firebase Web SDK plugin: functions Firebase Cloud Functions Priority: P1

Comments

@mbleigh
Copy link

mbleigh commented Feb 16, 2021

Issue

The iOS, Android, and JS SDKs for Firebase now support custom domain endpoints. In JS it looks like this:

const someFunc = firebase.functions("https://my.custom.url").httpsCallable("someFunc");
await someFunc({data: 'here'}); // calls https://my.custom.url/someFunc instead of cloudfunctions.net URL

This was a fairly recent addition since previously only a region could be passed to the factory method. It would be nice for the React Native library to catch up to the change in the other SDKs. Thanks!

@mbleigh mbleigh added help: needs-triage Issue needs additional investigation/triaging. type: bug New bug report labels Feb 16, 2021
@mikehardy mikehardy added impact: web-implementation An API in RNFB does not conform to the Firebase Web SDK plugin: functions Firebase Cloud Functions Type: Feature Request and removed help: needs-triage Issue needs additional investigation/triaging. type: bug New bug report labels Feb 16, 2021
@Salakar Salakar assigned Salakar and unassigned Salakar Feb 23, 2021
@invertase invertase deleted a comment from mikehardy Feb 23, 2021
@Salakar
Copy link
Member

Salakar commented Feb 23, 2021

Thanks @mbleigh we'll get this looked at.

@dackers86 or @russellwheatley - would you mind taking a look at this this week, I've added an internal ticket on the new board to track (RNFB-1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: web-implementation An API in RNFB does not conform to the Firebase Web SDK plugin: functions Firebase Cloud Functions Priority: P1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants