feat(analytics): add & deprecate pre-defined analytics events #3385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russellwheatley
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3385 +/- ##
==========================================
- Coverage 62.89% 56.52% -6.37%
==========================================
Files 113 108 -5
Lines 3705 3433 -272
Branches 192 0 -192
==========================================
- Hits 2330 1940 -390
- Misses 1328 1493 +165
+ Partials 47 0 -47 |
…-native-firebase into @russell/analytics-types
russellwheatley
changed the title
russellwheatley
changed the title
10 tasks
10 tasks
Salakar
reviewed
Jun 22, 2020
Salakar
reviewed
Jun 22, 2020
| /** | ||
| * Purchase currency in 3 letter [ISO_4217](https://en.wikipedia.org/wiki/ISO_4217#Active_codes) format. E.g. `USD`. | ||
| */ | ||
| //TODO if value is a param, so must currency: https://firebase.google.com/docs/reference/android/com/google/firebase/analytics/FirebaseAnalytics.Event#public-static-final-string-add_to_wishlist |
There was a problem hiding this comment.
I'm not actually sure about this. If currency is a property on the object then value must also be present.
I think we will have to update the event types to have something like this: https://stackoverflow.com/a/51507473 what do you think?
Salakar
requested changes
Jun 22, 2020
There was a problem hiding this comment.
Some additional points:
- Can we move the JS only tests to Jest: https://github.com/invertase/react-native-firebase/blob/master/packages/analytics/__tests__/analytics.test.ts @dackers86 can assist with this if needed
- Can we have a change log in the PR description of all the changes, like you did for the Remote Config PR
- Can you add eslint ignore comment lines on each of the
console.warnlines of the deprecations, like on the Remote Config PR - Can
types-test.tsbe updated to call the new apis to make sure types are functioning correctly
Ta
…-native-firebase into @russell/analytics-types
Co-authored-by: Mike Diarmid <[email protected]>
|
I've had to temporarily stop the |
…-native-firebase into @russell/analytics-types
Salakar
previously approved these changes
Jul 6, 2020
…-native-firebase into @russell/analytics-types
Salakar
approved these changes
Jul 6, 2020
andersondanilo
pushed a commit
to vixtech/react-native-firebase
that referenced
this pull request
Nov 9, 2020
…ase#3385) * updating analytics types * further type updates * update log events for analytics * update validation * feat(analytics): update events & tests * tests(analytics): update * build(analytics): types & type tests * chore(analytics): update to revised api * feat(analytics): further updates for package * Apply suggestions from code review Co-authored-by: Mike Diarmid <[email protected]> * tests(analytics): update tests * tests(ml-vision): stop testing ml-vision * chore(*): spelling * chore(*): spelling * chore(analytics): update ts docs Co-authored-by: Mike Diarmid <[email protected]> [publish]
andersondanilo
pushed a commit
to vixtech/react-native-firebase
that referenced
this pull request
Nov 9, 2020
…ase#3385) * updating analytics types * further type updates * update log events for analytics * update validation * feat(analytics): update events & tests * tests(analytics): update * build(analytics): types & type tests * chore(analytics): update to revised api * feat(analytics): further updates for package * Apply suggestions from code review Co-authored-by: Mike Diarmid <[email protected]> * tests(analytics): update tests * tests(ml-vision): stop testing ml-vision * chore(*): spelling * chore(*): spelling * chore(analytics): update ts docs Co-authored-by: Mike Diarmid <[email protected]> [publish]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3512
New API
New event methods added.
Removed API
API that now fires a
console.warn()when called.Unchanged or slight modifications
Following API may have changed in minor ways
currency&valueproperties which require the compound property check to ensure both are present if one is present.Notes
analytics.test.ts.