fix(firestore,ios): Settings incorrectly set multiple times #2869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where Firestore settings are incorrectly set multiple times rather than once.
Salakar
added
type: bug
Salakar
changed the title
androidIsForVivek
pushed a commit
to androidIsForVivek/react-native-firebase
that referenced
this pull request
Aug 9, 2021
…e#2869) * fix(firestore,ios): Firestore settings incorrectly set multiple times Fixes an issue where Firestore settings are incorrectly set multiple times rather than once. * refactor(firestore,ios): Misc code cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an iOS issue where Firestore settings are incorrectly set multiple times instead of once, as highlighted in #2866
Checklist
iOS