fix(messaging): typo in isRegisteredForRemoteNotifications #2645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the access of `native.isRegisteredForRemoteNotifcations` (missing `i`) to `native.isRegisteredForRemoteNotifications`, which matches the string defined in https://github.com/invertase/react-native-firebase/blob/master/packages/messaging/ios/RNFBMessaging/RNFBMessagingModule.m#L58 This also fixes the coercion of falsy values to `true`, which would have occurred if `native.isAutoInitEnabled` or `native.isRegisteredForRemoteNotifications` were initially `false`.
|
|
Salakar
approved these changes
Nov 23, 2019
Salakar
added
platform: javascript
plugin: messaging
Salakar
changed the title
hmhm2292
pushed a commit
to hmhm2292/react-native-firebase
that referenced
this pull request
Jul 13, 2021
…#2645) This changes the access of `native.isRegisteredForRemoteNotifcations` (missing `i`) to `native.isRegisteredForRemoteNotifications`, which matches the string defined in https://github.com/invertase/react-native-firebase/blob/master/packages/messaging/ios/RNFBMessaging/RNFBMessagingModule.m#L58 This also fixes the coercion of falsy values to `true`, which would have occurred if `native.isAutoInitEnabled` or `native.isRegisteredForRemoteNotifications` were initially `false`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the access of
native.isRegisteredForRemoteNotifcations(missingi) tonative.isRegisteredForRemoteNotifications, which matches the string defined in https://github.com/invertase/react-native-firebase/blob/master/packages/messaging/ios/RNFBMessaging/RNFBMessagingModule.m#L58This also fixes the coercion of falsy values to
true, which would have occurred ifnative.isAutoInitEnabledornative.isRegisteredForRemoteNotificationswere initiallyfalse.Summary
Checklist
AndroidiOSe2etests added or updated in /tests/e2e/*Test Plan
Release Plan
[JS][BUGFIX] [Messaging] - Fix typo of isRegisteredForRemoteNotifications
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter