Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backoffice: Purchase orders edit form performing too many requests #213

Open
jrcastro2 opened this issue Oct 1, 2020 · 1 comment
Open
Labels
bug Something isn't working minor refactor

Comments

@jrcastro2
Copy link
Contributor

Describe the problem

In the "acquisition order edition form" we are performing 6 requests as minimum, plus 4 requests for each additional order line. This means that an adquisiton order with 6 order lines is performing 26 requests. We have to look for a solution to prevent a request each time we render a vocabularyField. (Redux could be a solution).

Steps to reproduce

  1. Search for an acquisition order with 5 or more order lines.
  2. Edit it and check in the invenio-app-ils console the requests (or the network tab in the devtools).

Related to: #192

@jrcastro2 jrcastro2 added the invalid This doesn't seem right label Oct 1, 2020
@kpsherva kpsherva added bug Something isn't working refactor and removed invalid This doesn't seem right labels Oct 1, 2020
@kpsherva kpsherva added the minor label Oct 28, 2020
@FlorianCassayre FlorianCassayre mentioned this issue Nov 6, 2020
13 tasks
@ntarocco
Copy link
Contributor

One possible solution would be to add a max-age: x seconds cache header in the axios request so that same requests, for same vocab, are cached after the first request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor refactor
Projects
None yet
Development

No branches or pull requests

3 participants