Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElasticsearchDumper loading types #276

Open
ppanero opened this issue Mar 17, 2022 · 0 comments · May be fixed by #274
Open

ElasticsearchDumper loading types #276

ppanero opened this issue Mar 17, 2022 · 0 comments · May be fixed by #274

Comments

@ppanero
Copy link
Member

ppanero commented Mar 17, 2022

is load_type necessary? The issue raised from the usage of PIDStatus.

It must be dumped as a str due to ES (PIDStatus is not JSON serializable). Then, when stored in DB it all workes because the impl of the ChoiceType is Char(1). However, if it was different it would cause problems.

The dumper should in this case be aware of loading it as the type it was before being dumped (find a way to map ChoiceType.choices)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants