Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate invocation of install command in Setup documentation #162

Open
ghost opened this issue May 17, 2018 · 0 comments
Open

Duplicate invocation of install command in Setup documentation #162

ghost opened this issue May 17, 2018 · 0 comments
Labels

Comments

@ghost
Copy link

ghost commented May 17, 2018

Steps 5 and 7 of the Setup section of the docs tell the user to run the same command. Is this intentional?

  1. Then run the install command: php artisan authentication:install
    Note: you need to setup your database configuration before running the command, check out: configuring laravel database
    Now you can find various configuration files under config/ folder.

  2. Now open the file app/Http/Kernel.php and add the following lines to your $routeMiddleware array:
    'admin_logged' => \LaravelAcl\Http\Middleware\AdminLogged::class,
    'logged' => \LaravelAcl\Http\Middleware\Logged::class,
    'can_see' => \LaravelAcl\Http\Middleware\CanSee::class,
    'has_perm' => \LaravelAcl\Http\Middleware\HasPerm::class,

  3. Now you need to install the application, to do that run the command: php artisan authentication:install.

If so, then perhaps step 7 could say, "run the install command again", to make clear to the reader that the repetition is not a mistake; and should ideally also explain the rationale behind running the same command twice.

@ghost ghost changed the title Duplicate entry in Setup documentation Duplicate invocation of install command in Setup documentation May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant