Proposal

We currently have a vue component, AuthorIdentifiers, we use on the authors page for this purpose (eg see the "Identifiers" section on https://openlibrary.org/authors/OL716700A/Francine_Pascal/edit ). We have a very similar component on the editions page for adding edition identifiers (eg Go to the edition tab, and then the "Identifiers" section of https://openlibrary.org/books/OL1088853M/Wizard's_First_Rule/edit ) which does not use Vue. We would like to expand AuthorIdentifiers with some new options to have it support edition identifiers, and then replace the edition identifiers with this new component.

How do they differ?

For legacy reasons, there are some slight differences as to how identifiers are stored on authors vs editions. We want to expand the vue component to support both schemes.

Authors:

Stored like this on the author record (eg https://openlibrary.org/authors/OL716700A/Francine_Pascal.json )

{
    "remote_ids": {
        "viaf": "12319102"
    },
}

And its passed as a prop the identifiers from https://openlibrary.org/config/author .

Editions:
Stored like this on the edition record (eg https://openlibrary.org/books/OL1088853M.json)

{
    "identifiers": {
        "goodreads": ["914886"],
        "librarything": ["4070590"],
    }
}

Note it's a list. The possible identifiers should be passed in from the edition config.

Justification

Breakdown

Requirements Checklist

• Expand AuthorIdentifiers with two new options:
  • multiple: true/false -- whether it's a list or a single value
  • input-prefix: str -- where to save; e.g. author--remote_ids-- for authors, or edition--identifiers-- (or something like this; might need tweaking)
• Update the edition edit page, to render the new component.
• Incorporate any extra validation / etc in the existing edition identifiers into the
• Delete the code for the old edition identifiers selection
• Rename AuthorIdentifiers to IdentifiersInput and update all references.

Tests

• Confirm adding an IA edition is still restricted to super-librarians, as before.
• Can add multiple IA identifiers to editions per identifier-type
• Can delete identifiers on editions
• Can add only one identifier to authors
• Can delete identifiers on authors

Related files

• https://github.com/internetarchive/openlibrary/blob/e7c202dc38ac621c645c5d53b519e71d7586e76b/openlibrary/components/AuthorIdentifiers.vue
• https://github.com/internetarchive/openlibrary/blob/d8454f73805b699fff1b4c6a3f2f482d162b82c8/openlibrary/templates/books/edit/edition.html
• https://github.com/internetarchive/openlibrary/blob/d8454f73805b699fff1b4c6a3f2f482d162b82c8/openlibrary/plugins/openlibrary/js/edit.js

• openlibrary/openlibrary/templates/type/author/edit.html

  Lines 106 to 110 in 622694d

  	<div class="label">$_("Identifiers") <a href="/help/faq/editing.en#author-identifiers-purpose"><img src="/images/icons/icon_help.png" alt="$_('Author Identifiers Purpose')"/></a> </div>
  	<div id="hiddenIdentifierInputs"></div>
  	<div id="identifiers-display">
  	$:render_component('AuthorIdentifiers', attrs=dict(assigned_ids_string=dict(page.remote_ids),output_selector='#hiddenIdentifierInputs',author_config_string=dict(get_author_config())))
  	</div>

Stakeholders

@mheiman @RayBB

Instructions for Contributors

Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.