Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Merge Queue: Allow librarians to submit deletion requests #10033

Open
1 task
RayBB opened this issue Nov 17, 2024 · 0 comments
Open
1 task

Expand Merge Queue: Allow librarians to submit deletion requests #10033

RayBB opened this issue Nov 17, 2024 · 0 comments
Labels
Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@RayBB
Copy link
Collaborator

RayBB commented Nov 17, 2024

Proposal

Fairly often, in the librarian Slack channel people request entries to be deleted (calendars, etc) that aren't suited to merging.
I'm sure some people also just submit the request form to ask this to be done.

To ease this burden we should extent the merge queue to also have a deletion queue.
@seabelis gave a thumbs up to this idea here.
Preferably worded in a way that says “this is not a book” rather than “delete this”.

Justification

It makes it easier for librarians to keep our dataset clean.
It also makes once consistent place for super librarians to review such requests.

The impact of this is relatively small as deletions are much fewer than merges but it will be yet another tool in our belt for a great experience of contributors.

Breakdown

Requirements Checklist

This will need to be broken down more but initial thoughts

  • It should basically mirror the current merge queue with the exception of
    • You only need to select one item to suggest a deletion

Related files

Stakeholders


Instructions for Contributors

Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.

@RayBB RayBB added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Nov 17, 2024
@cdrini cdrini added Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] and removed Needs: Lead labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Development

No branches or pull requests

2 participants