Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact form errors on submit #10030

Open
cdrini opened this issue Nov 14, 2024 · 1 comment
Open

Contact form errors on submit #10030

cdrini opened this issue Nov 14, 2024 · 1 comment
Assignees
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 1 Do this week, receiving emails, time sensitive, . [managed] Type: Bug Something isn't working. [managed]

Comments

@cdrini
Copy link
Collaborator

cdrini commented Nov 14, 2024

Problem

image

Triggered in our code from here:

else:
web.sendmail(from_address, to_address, subject, message)

Reproducing the bug

  1. Go to https://openlibrary.org/contact
  2. Submit the form
  • Expected behavior: The email is sent and a success message appears
  • Actual behavior: An error screen appears

Context

  • Browser (Chrome, Safari, Firefox, etc): FF
  • OS (Windows, Mac, etc): Win
  • Logged in (Y/N): Y
  • Environment (prod, dev, local): prod

Breakdown

Requirements Checklist

  • [ ]

Related files

Stakeholders


Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@cdrini cdrini added Type: Bug Something isn't working. [managed] Priority: 1 Do this week, receiving emails, time sensitive, . [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] labels Nov 14, 2024
@cdrini cdrini added this to the Sprint 2024-11 milestone Nov 14, 2024
@cdrini cdrini self-assigned this Nov 14, 2024
@cdrini
Copy link
Collaborator Author

cdrini commented Nov 18, 2024

Consider switching to a mailto: link to just circumvent this whole problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 1 Do this week, receiving emails, time sensitive, . [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Development

No branches or pull requests

1 participant