Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BookReader not loading higher-resolution images for high DPI screens by default #1322

Open
heliumtext opened this issue Mar 11, 2024 · 0 comments

Comments

@heliumtext
Copy link

I've noticed on archive.org that the book reader doesn't take advantage of high resolution screens (e.g. on Macs and iPhones) and the images therefore look a bit blurry unless you zoom in. I see that this was fixed a few years ago in #378 by using srcset, but it looks like the code was rewritten since then; there's still support for it, controlled by useSrcSet in src/BookReader/options.js where the default is useSrcSet: false, even though the comment above it says "On init, by default, we want to use srcSet for images." I tried changing that line to useSrcSet: true and it seems to work correctly that way. The default was changed from true to false in #651 and I don't see an explanation for why in the commit note. Was this intentional or could we change it back to true? I find it makes a big difference in legibility when reading books on small screens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant