Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in a constructor property #1301

Open
manish0kuniyal opened this issue Dec 30, 2023 · 1 comment
Open

Typo in a constructor property #1301

manish0kuniyal opened this issue Dec 30, 2023 · 1 comment

Comments

@manish0kuniyal
Copy link

Description

In the file search-results.js which is inside src/BookNavigator/search/search-results.js there is a typo. In the IABookSearchResults class, there is a property named renderSearchAllFields in the constructor, but the correct property name is renderSearchAllFiles according to the static properties definition.

Evidence / Screenshot (if possible)
image

Expectation

Instead of:

this.renderSearchAllFields = false;

It should be:

this.renderSearchAllFiles = false;
@manish0kuniyal manish0kuniyal mentioned this issue Dec 30, 2023
Closed
@sahalbelam
Copy link
Contributor

hey, i have fixed this typo can i make a pr now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes : Typo Error In IABookSearchResults Class
2 participants
@manish0kuniyal @sahalbelam