Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List upload: add tests for organism #37

Open
julie-sullivan opened this issue May 20, 2019 · 5 comments
Open

List upload: add tests for organism #37

julie-sullivan opened this issue May 20, 2019 · 5 comments
Assignees

Comments

@julie-sullivan
Copy link
Member

See comments here: #36

The testmodel has an idea of an extraValue. I forget what it is, company department maybe?

@julie-sullivan
Copy link
Member Author

Also, @yochannah you updated the tutorial to include this new feature. Is that right? Can you make that live too?

@22PoojaGaur
Copy link
Member

22PoojaGaur commented Feb 25, 2020

Hi @julie-sullivan @yochannah ,
I am new to this org. I would like to take up this issue to start contributing.

@22PoojaGaur
Copy link
Member

I explored the test structure. Here are my observations ->

  • The test for lists are stored in test_lists.py and mock data of test lists is stored in tests/testservice/service/list. But this test file contains test for only getting list while changes in Committing organism specification on list upload functionality #36 are in create_list.
  • Then I saw that you have mentioned extraValue. This is in test_core.py file. Since organism has constraint ONE OF it should be part of testMultiConstraint.

So, should I make changes to testMultiConstraint. Or am I making any mistake?

@22PoojaGaur
Copy link
Member

Also, as you had asked -> it appears extraValue is indeed Employee.department as used in line 865 in test_core.py

@yochannah
Copy link
Member

yochannah commented Feb 28, 2020

Hey @22PoojaGaur! You would be very welcome to take a look at this :) your deducations sound correct to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants