Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[easier if you have familiarity with node] review contributing docs and ensure project builds #182

Open
yochannah opened this issue Oct 23, 2019 · 11 comments

Comments

@yochannah
Copy link
Member

IT would be nice to review our contributing docs and make sure they have all the info you need in order to build this project.

Task:

  1. Clone this repo and read through the contributing md.
  2. Try to build a working copy of im-tables. If you're unsure about anything please ask for help by mentioning @yochannah and make sure to add these notes to our contributing docs for the next person.
  3. Make a PR with any changes you've made to the docs.

if you want to pick up this task

  1. Take a look at the InterMine contributing guidelines
  2. Comment on this issue stating that you intend to work on the task
  3. When you're ready, add your work to the repo and create a pull request.

What to do if you need help

Mention @yochannah, tweet @yoyehudi, pop by to say hi on chat or if needed email [email protected]. Don't forget we're usually only available during uk office hours and will not be able to respond at other times :)

@abhisheknaiidu
Copy link

@yochannah hi, I am actually new to open source, could you plz help me out in this, actually I'm trying to build a copy locally, but when im running npm start command it shows this error and i also tried it with sudo as well :

in

@yochannah
Copy link
Member Author

Hey @abhisheknaiidu - thanks for making a start with this task! You're right, that argument doesn't work anymore - I think the serve package must have discontinued it. Luckily,-p still works even where --port doesn't. I've pushed a tiny change to this GitHub repo - if you pull dev again does it work?

@abhisheknaiidu
Copy link

@yochannah hmm, when i pulled it again from this repo, then it doesn't show any error, but its not opening then also :

im1

And when I run npm run dev command it shows this :

Screenshot from 2019-12-23 17-19-53

@yochannah
Copy link
Member Author

Right, so npm run dev does what I'd expect it to - that is good!

npm start still looks dodgy - let me see what is going on.

@abhisheknaiidu
Copy link

@yochannah have you figured that out ?? because even now also, I am not able to serve it properly in the browser.

@bistaastha
Copy link

@abhisheknaiidu Hi! Are you still working on this?

@mcastorena0316
Copy link

Hi, my name is Melissa from Outreachy and I intend to work on this task, do I need a confirmation? Thank and have a wonderful day

@GraceChiamaka
Copy link

Hi @yochannah I would like to work on this issue. I am an Outreachy applicant. Thanks

@yochannah
Copy link
Member Author

@mcastorena0316 thanks, I'll assign this to you now. Looking at some of the previous notes and linked issues, it's possible everything is working nicely now, but having someone else run through and confirm this would still be really valuable.

Others - thanks for volunteering! 💖 if you're having trouble finding issues to volunteer for, my advice is to try checking out a repository you're interested in and seeing if you can spot any improvements or bugs, then making issues for those. Thanks for being so patient!

@mcastorena0316
Copy link

Hi @yochannah, I already checked the documentation, here is what I found:

  • I was able to make the installations and run the project with no problem on my computer, I tried everything and it seems to work. The instructions were clear in that section.

-The page runs without any problem, and all the links seem to be working.

-On testing, when I use the command grunt watchTests it just freezes, but I was able to run the tests using the command npm test (Can I update the document with this? I can delete the section with watchTest or maybe add a new one)

  • The testing was only successful with Unit test, the other ones were rejected, cause I wasn't able to run a data server running the intermine-demo application at port 8080. (I tried with the instructions of github/intermine/intermine but I have no luck, do you have any tips or extra info I can use to achieve this?)

-Other than that, I just correct some grammar mistakes, and that's really it all.

-I'm sending pictures of the result of all my tryouts. I will be waiting for more instructions on how to proceed. Sorry for the big text. Thank you.

Terminal - mcastorena0316@mcastorena0316-VirtualBox: ~-Desktop-Outreachy-im-tables_003

Terminal - mcastorena0316@mcastorena0316-VirtualBox: ~-Desktop-Outreachy-im-tables_004

Terminal - mcastorena0316@mcastorena0316-VirtualBox: ~-Desktop-Outreachy-im-tables_001

Mozilla Firefox_002

@mcastorena0316
Copy link

  • I was thinking as well, maybe we can add to the document of Contributing how to submit your contribution (maybe the sequence: create a new branch, make a pull request, and submit the contribution).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants