Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

Spacing on http://intermezzos.github.io/book/ #1

Closed
photomattmills opened this issue Dec 25, 2015 · 7 comments
Closed

Spacing on http://intermezzos.github.io/book/ #1

photomattmills opened this issue Dec 25, 2015 · 7 comments
Labels

Comments

@photomattmills
Copy link

I can't seem to repro locally, but a lot of words seem to be missing spaces between
(e.g. ss of problem text from the first paragraph). I'm on OSX Yosemite with Chrome. Could be it just needs a re-deploy?

@steveklabnik
Copy link
Member

It's an upstream bug of an upstream bug, actually: https://github.com/azerupi/mdBook/issues/76

@AnthIste
Copy link

+1 for OSX Yosemite and Chrome

@photomattmills
Copy link
Author

@steveklabnik would you accept a PR of the newlines converted to spaces in the meantime? I figured out the regex/replace for it, wouldn't be hard. I don't want to mess with anyone's workflow, though.

@flounders
Copy link

I'm experiencing the same thing with Arch and Firefox. I think just replacing the newlines with spaces will fix the issue for the browser, but reading through the markdown files would be a pain. The better solution would be to prefix the newline with a space or postfix it. That way the formatting is more a less preserved in markdown and on the page. Ideally the bug should be fixed in upstream.

@steveklabnik
Copy link
Member

@MattMills I share @flounders 's opinion, we should just fix this upstream. It might be a bit awkward for a few days, but that's better than reformatting everything and then reformatting it back, I'd say.

If it were going to be wrong upstream for months, then I'd consider it.

@photomattmills
Copy link
Author

@steveklabnik fine with me. Still a bit odd that it doesn't build that way on my local machine.

@photomattmills
Copy link
Author

Going to close this since the upstream stuff appears to be fixed. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants