Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Admin UI displays liquidity in one asset scale and withdrawal input in a different scale #2798

Closed
JoblersTune opened this issue Jul 9, 2024 · 5 comments · Fixed by #2817
Labels
good first issue Good for newcomers pkg: frontend Changes in the frontend package. type: bug Something isn't working

Comments

@JoblersTune
Copy link
Collaborator

Bug Report

Describe the bug

When you view liquidity information it is displayed in asset scale two but when withdrawing liquidity it converts back to the original asset scale without warning the user.

Expected behavior

Either make it clear to the user that the asset scale has changed, or even better, make the asset scale consistent.

Screenshots

image
image
image

@JoblersTune JoblersTune added type: bug Something isn't working good first issue Good for newcomers pkg: frontend Changes in the frontend package. labels Jul 9, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Rafiki Jul 9, 2024
@Emanuel-Palestino
Copy link
Contributor

Hello, can i try to solve this issue? Or is someone working on it right now?

The expected result based on your screenshots is 9999999900.60 USD right? So the problem is that it is ambiguous on what scale the user is withdrawing or depositing, correct?

@JoblersTune
Copy link
Collaborator Author

JoblersTune commented Jul 17, 2024

@Emanuel-Palestino that would be lovely. Thanks for the offer of help!

The expected result based on your screenshots is 9999999900.60 USD right? So the problem is that it is ambiguous on what scale the user is withdrawing or depositing, correct?

Yes, exactly!

If you have any more questions, or have any trouble spinning up the Admin UI, please feel free to ask.

@JoblersTune
Copy link
Collaborator Author

For some additional context that might be helpful:

  • I think this is a problem comes up for withdrawing or depositing liquidity for peers, assets, incoming and outgoing payments, and wallet addresses.
  • The bug shows up whenever asset scale is not set to 0.
  • The approach may be to use the loaders to get asset details and pass them into the liquidity dialog so that we can at least display 1 = $0.01 for instance.
  • Also open to other suggestions if you have a different approach.

@Emanuel-Palestino
Copy link
Contributor

Emanuel-Palestino commented Jul 18, 2024

@JoblersTune I opened a pull request #2817 implementing your approach c:

@JoblersTune
Copy link
Collaborator Author

Fantastic @Emanuel-Palestino, thank you. I am out of office but will review on Wednesday when I am properly back at my desk.

@github-project-automation github-project-automation bot moved this from Backlog to Done in Rafiki Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers pkg: frontend Changes in the frontend package. type: bug Something isn't working
Projects
Status: Done
2 participants