Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass page in User.all #17

Closed
PanosJee opened this issue Jul 27, 2013 · 8 comments
Closed

Pass page in User.all #17

PanosJee opened this issue Jul 27, 2013 · 8 comments
Assignees
Milestone

Comments

@PanosJee
Copy link

Right now you can only get 500 users and there is no way to pass the page or per_page attribute

@ghost ghost assigned jkeyes Aug 10, 2013
@jkeyes
Copy link
Contributor

jkeyes commented Aug 10, 2013

This is pencilled in for the 0.2.9 release. See d827dc3 and 58f5ed3 for implementation details.

@jkeyes
Copy link
Contributor

jkeyes commented Aug 10, 2013

I've added support for this to User.all but I'll be reverting that behaviour. As per the official Ruby library all will return all of the users. The additional search attributes will be exposed on the User.find method instead.

@jkeyes
Copy link
Contributor

jkeyes commented Aug 10, 2013

The page, per_page, tag_id, and tag_name parameters are now supported on Intercom.get_users only. Not sure why I even ventured in User land as it's just not needed there.

@jkeyes jkeyes closed this as completed Aug 10, 2013
@timdawborn
Copy link

Is there an ETA for the 0.2.9 release? I notice that the date of the Github milestone is now a month over.

@jkeyes
Copy link
Contributor

jkeyes commented Oct 21, 2013

I'll get my ass in gear on this soon (next week or so), other work taking priority right now.

@jkeyes
Copy link
Contributor

jkeyes commented Nov 16, 2013

@timdawborn
Copy link

Great, thanks!

@jkeyes
Copy link
Contributor

jkeyes commented Nov 16, 2013

Apologies for my tardiness. 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants