Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jQuery.prop for relative href #78

Open
jlami opened this issue May 23, 2017 · 0 comments
Open

Use jQuery.prop for relative href #78

jlami opened this issue May 23, 2017 · 0 comments

Comments

@jlami
Copy link

jlami commented May 23, 2017

Hi,

I must first add that we use ember-href-to in a weird way. We don't use the helper, but use the global click handler to make custom href links work. These links are 'user-generated', and this addon makes those links integrate with ember without the user having to know the route names.

This however does not work for relative names. While we can get the href's correctly pointing to the correct url's the addon does not recognize them as it uses the href attribute, which for relative uri's never begins with the root. This then marks these links as 'external'.

Maybe we could use jQuery.prop to get the complete uri that the href will point to? This does have the side-effect that the uri will contain the hostname, but maybe recognizing this will fix some problems concerning the external links not working? #63 #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant