Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yaru Todos #20

Open
18 tasks
okwme opened this issue Jul 5, 2021 · 0 comments · May be fixed by #21
Open
18 tasks

Yaru Todos #20

okwme opened this issue Jul 5, 2021 · 0 comments · May be fixed by #21
Assignees

Comments

@okwme
Copy link
Contributor

okwme commented Jul 5, 2021

  • Use pooltoy and slackbot. Fix anything that seems broken, and think about ways to make it better (easier, more stable, more reliable, better access, easier to understand. Be a good user)
  • Add the changes seen here so that pooltoy can use the new config option of v0.42.6
  • Make a PR against the pooltoy repo with updates to pooltoy including the init.sh script, update to v0.42.6, and implementation of config as outlined in the previous item.
  • Manually go over the code and make sure each command works. This will help you identify things that are broken and that would ideally be caught by tests in the future (like the broken send command)
  • Add tests wherever possible
    • This may mean adding commands for installing pooltoy and running initialization scripts so that the tests have something to run against.
    • This may also mean adding commands to talk to slack correctly. Technically there is another slack channel called #intrachain-dev but it is still using the same slackbot. If we wanted to get really serious about this we should have two slack bots running. One for production and one for development. The development slackbot could maybe be used for testing? Might be overkill for now.
    • A third option that might help with both of the other two is to "stub" out the stateful aspects of the tests. This would mean that you "fake" the responses from pooltoy commands or the responses you'd get from the slack server. This is only helpful if those stubs are also always update, so the tests won't necessarily be as helpful anymore.
    • I'd maybe suggest doing the fully integrated test system and just be very careful about making sure the tests are sensitive to the fact that the state may be different at any time. Also maybe making use of the #intrachain-dev so that people in the company don't get a lot of unnecessary notification lol
  • potential new features
    • let users export their private keys so that if they have pooltoy installed locally, they can also interact with it
    • let users send IBC transfer packets (will involve getting a relayer set up and running that connects pooltoy with the cosmos hub for example)
    • add NFTs to pooltoy (replace emojis with NFTs?)
    • who has the most emojis
    • escrow exchange / offer emojis
      • two versions
        • simple version - i offer X in exchange for Y. Once someone offers Y, the module "atomically" exchanges the assets. Until an offer is accepted, it can be canceled.
        • complicated version - i offer X. anyone can offer Y, X, Q etc in exchange for X. If i accept offer, they are "atomically" exchanged. I can deny offers. If I have multiple offers and I accept one offer, all the rest are denied. Until an offer is accepted, it can be canceled.
@yaruwangway yaruwangway linked a pull request Jul 8, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants