Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvement LCS #7

Merged
merged 2 commits into from
Jun 13, 2017

Conversation

SeHeGit
Copy link
Contributor

@SeHeGit SeHeGit commented Jun 13, 2017

Initial freeze of genes drastically improves runtime for long arrays.

SeHeGit added 2 commits June 13, 2017 07:13
Initial freeze of genes drastically improves runtime for long lists.
@gliechtenstein gliechtenstein merged commit 6d706fa into intercellular:develop Jun 13, 2017
@gliechtenstein
Copy link
Contributor

Gorgeous! This effectively cuts down the complexity of the entire library significantly.

Thank you for the PR!

@SeHeGit
Copy link
Contributor Author

SeHeGit commented Jun 13, 2017

You're welcome. I am currently testing several use cases and this was an issue I had with a custom table implementation.
While there is still room for improvement in the LCS problem, I didn't want to implement a more complex algorithm. May be worth runtime-wise but lacks the clarity and shortness of your implementation.

@gliechtenstein gliechtenstein mentioned this pull request Jun 21, 2017
suryapratap pushed a commit to suryapratap/cell that referenced this pull request Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants