-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for React Router v4 #323
Comments
Catalog itself depends on react-router v3, so I think we might be out of luck until we change that. A workaround would be to not rely on any router-specific code in the components documented with Catalog but I'm aware that this may not be an option. @wereHamster ran into this issue too if I remember correctly. How did you solve that? |
I did some research and contrary to my last message I don't think it should actually be a problem to have both versions co-exist. We have a setup where the app depends on |
It's not just the npm warning about peer dependencies. There's an actual runtime error:
|
Can you attach the output from |
For reference here's mine (npm v5.4.2):
|
I'm confused by this line: |
I'm using |
Is it an option for you to upgrade to npm v5 or yarn? That would probably solve your problem. |
Unfortunately it isn't an option for me to upgrade to npm v5 or yarn at this point. Is there an alternate solution for this issue? |
Since this is really a dependency issue, I don't think there's a reliable way to fix this. npm v3's installs are non-deterministic, and the order in which you install modules produces different results. The only way to get a reliable-ish install is removing Maybe installing Catalog in its own subdirectory could work but I'm not too sure, e.g.:
|
I can certainly give that a shot. Will that work using Catalog as a standalone npm module import? |
If imported from within the subdirectory (e.g. |
Hi there. I would really like to use the "module" version of Catalog in my React project, but it is currently incompatible due to your dependency on
react-router-scroll
which does not support React Router v4. There's currently an open issue there to support it, as well as a fork. I'm not sure if there's an alternative solution until that matter is resolved. Any advice would be appreciated.The text was updated successfully, but these errors were encountered: