Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

images assume that containers have internet access #7

Closed
woodsaj opened this issue Sep 15, 2016 · 6 comments
Closed

images assume that containers have internet access #7

woodsaj opened this issue Sep 15, 2016 · 6 comments

Comments

@woodsaj
Copy link

woodsaj commented Sep 15, 2016

The images try and pull down the latest snap binaries when the container starts. If the containers are running inside environments with limited or no internet access, then the containers cant start.

Why cant the Dockerfiles just pull the binaries into the docker image at build time and tag the image with the build version.

@nanliu
Copy link
Contributor

nanliu commented Sep 21, 2016

We have a few image that has snap version which contains the binary, for example: intelsdi/snap:0.15_xenial.

These prebuilt images don't have an automated update process, so until we have automated docker image build process I think the current binary fetch seems like a good compromise for testing purpose. I'm planning to delete the latest_* tags until we have an automated process in place.

@woodsaj
Copy link
Author

woodsaj commented Sep 22, 2016

ok, but if these docker images are only for testing purposes that should be made clear in the description on dockerhub.

Are there any plans to produce images that users can use in real environments?

@nanliu
Copy link
Contributor

nanliu commented Sep 22, 2016

We are planning to change the s3 output for snap to match the plugins with arch/os. I will circle back to the docker repo once we resolve this issue:

intelsdi-x/snap#1205

@nanliu
Copy link
Contributor

nanliu commented Sep 24, 2016

See WIP #10 for goal to split off the docker images. This will take a bit longer, since the change to snap binary output is affecting a bunch of test.

@nanliu
Copy link
Contributor

nanliu commented Oct 21, 2016

@woodsaj, the new containers ship with binary included. The download behavior is limited to *_test containers. Please let us know if this addresses your concern.

@woodsaj
Copy link
Author

woodsaj commented Oct 24, 2016

yes it does. Thanks.

@woodsaj woodsaj closed this as completed Oct 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants