Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Formatting inconsistency -- yapf tests #175

Open
Wackerbarth opened this issue Jan 16, 2019 · 0 comments
Open

Formatting inconsistency -- yapf tests #175

Wackerbarth opened this issue Jan 16, 2019 · 0 comments

Comments

@Wackerbarth
Copy link
Contributor

I observe that PR#169 includes a trivial change to the last line of particular files that does not affect the parsing of that file.

In one version, the line ends with a newline. In the other, it ends with the end-of-file and no terminating new-line.

Basically, this is the difference in having the newline character be a line separator or having it be the terminal character of each line.

I would prefer that one, or the other, convention be used throughout.
In particular, I suggest that we not have a filter that allows both, thus failing to flag trivial changes from one form to the other.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant