Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run test configuration with combination. #50

Merged
merged 2 commits into from
May 17, 2024
Merged

Run test configuration with combination. #50

merged 2 commits into from
May 17, 2024

Conversation

mxu9
Copy link
Contributor

@mxu9 mxu9 commented Apr 29, 2024 •
edited
Loading

Fix #46

With below Configuration (default + pcrc)

[Configuration_1]
type            = selective_ide
default         = 1
pcrc            = 1

The test is like below:

[2024-05-16 00:02:09.477]
[2024-05-16 00:02:09.477]  Print test results.
[2024-05-16 00:02:09.477]  TestSuite_1 - pass: 1, fail: 0, skip: 0
[2024-05-16 00:02:09.477]    TestConfiguration (Default+PCRC)
[2024-05-16 00:02:09.477]      TestGroup (SelectiveIDE Test) - pass: 1, fail: 0, skip: 0
[2024-05-16 00:02:09.477]        Test.1: case - pass; ide_stream_secure - na
[2024-05-16 00:02:09.477]

@mxu9 mxu9 mentioned this pull request Apr 29, 2024
Closed
@mxu9 mxu9 marked this pull request as draft April 30, 2024 00:49
mxu9 added 2 commits May 16, 2024 03:04
@mxu9
Test configuration combination
6fd365a 
Signed-off-by: Min Xu <[email protected]>
@mxu9
Refactor Default and PCRC config
60f8431 
Previously Configurations are tested one by one. So each Configuration
calls common functions (such as common_support, common_enable,
common_disable, etc) before calling Configuration specific functions.

After implementing the configuration combination, the common functions
are called in do_run_test_config_xxx. So this patch removes the common
calls in Default and PCRC config codes.

Signed-off-by: Min Xu <[email protected]>
@mxu9 mxu9 marked this pull request as ready for review May 16, 2024 07:09
@mxu9 mxu9 requested a review from jyao1 May 16, 2024 07:09
@jyao1 jyao1 merged commit ffbce4e into intel:main May 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyao1 jyao1 jyao1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run test configuration with combination.
2 participants
@mxu9 @jyao1