Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Duplicate files in dynamic_vino_lib and vino_param_lib #94

Open
Corsair-cxs opened this issue Feb 3, 2021 · 1 comment
Open

Duplicate files in dynamic_vino_lib and vino_param_lib #94

Corsair-cxs opened this issue Feb 3, 2021 · 1 comment

Comments

@Corsair-cxs
Copy link
Contributor

Hi, I find that there are two slogs.h in dynamic_vino_lib/include and vino_param_lib/include . Those files' functions are identical because both of them can implement a stream which is for logging.

May be we could merge those files?

@LewisLiuPub
Copy link
Contributor

The reason to keep duplicated slogs.h file is that dynamic_vino_lib and vino_param_lib belong to different ROS package. One of the suitable ways is to make a separate lib or package to archive the duplicated files.
Let's deeply think the suitable solution before making actions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants