42compress #142
Open
42compress #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 21, 2024
mkorbel1
reviewed
Nov 25, 2024
mkorbel1
reviewed
Dec 10, 2024
| if (use42Compressors) { | ||
| carryColumns = List.generate(pp.maxWidth(), (i) => ColumnQueue()); | ||
| } | ||
| // if (use42Compressors) { |
There was a problem hiding this comment.
delete unused if statement code?
| } | ||
| } | ||
| rowBits.addAll(List.filled(pp.rowShift[row], Const(0))); | ||
| // rowBits.addAll(List.filled(pp.rowShift[row], Const(0))); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
Adds 4:2 compressors option to ColumnCompressor as well as a better delay table for optimizing the compression tree.
Added a popCount as a LogicValue extension which may need to be migrated to ROHD itself (along with majority). Eventually we will need hardware versions of these.
Related Issue(s)
#120 #86
Testing
Modified tests to enable the 4:2 compression option.
Backwards-compatibility
compression trees will take on a different shape with different delay tables as the delay optimization gets more realistic.
Documentation
Yes. Code is updated. We could update the component generation to expose this option as well as we need to update the documentation of multipliers that use this option.