[MultiCycleDivider] Patch of prior bug fix to properly support unsigned division #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
This patch addresses a bug in the previous fix for MultiCycleDivider (proper support for unsigned division) that caused certain division operations to be performed incorrectly due to checking of improper bits.
Related Issue(s)
Testing
Added an explicit unit test on a known case where pre-patch functionality was broken.
Backwards-compatibility
This is fully backwards compatible as the patch is entirely internal to the implementation.
Documentation
No explicit documentation was required for the patch but documentation was still enhanced to discuss performance of the module in more detail (motivated by this fix).