Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix signed operand mode in multiplier, added pipelining #137

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

desmonddak
Copy link
Contributor

Description & Motivation

Fixed a bug in sign extension that was causing signed operand mode of multiplier to fail (if first operand was signed).

Related Issue(s)

None

Testing

Both exhaustive and random testing including ALL sign extension modes, across all radixes and prefix tree types, signed, unsigned, both fixed and logically selected, across critical width transitions, as well as for the multiply-accumulate and pure multiply.

Simple pipeline testing added to make sure timing is correct.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No, but new parameters with defaults extend the multiplier to expose sign selection types and pipelining.

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

Changes to the operation in the code comments and in the documentation. The configuration in the web confapp has been
updated to allow for pipeline selection. Sign extension type is not yet exposed in app.

@desmonddak desmonddak requested a review from mkorbel1 November 15, 2024 19:23
@desmonddak desmonddak merged commit 199bc7d into intel:main Nov 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant