Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect TLV value being evaluated #109

Open
penguin359 opened this issue Aug 13, 2024 · 0 comments
Open

Incorrect TLV value being evaluated #109

penguin359 opened this issue Aug 13, 2024 · 0 comments

Comments

@penguin359
Copy link
Contributor

It looks like an incorrect check is being done for the TLV type in the ecp_rx_ProcessFrame() function in qbg/ecp.c. Right after a new, unpacked TLV is created, a check is done on the decoded tlv_length value and the tlv->type from the, currently blank, unpacked TLV structure. This should be tlv_type from the recently decoded structure above.

I am just documenting this as it was caught while reviewing PR #104, but it is a pre-existing issue. It should be a quick fix once I have time.

          "I'm seeing other issues in this function besides memory leaks. I'll probably create a PR for it once I've had more time to review it. In any case, I would combine this free with a `tlv = NULL;` for safety."

Originally posted by @penguin359 in #104 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant