Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assign device id to pciBusID in delegated config #307

Merged
merged 2 commits into from
May 16, 2019
Merged

assign device id to pciBusID in delegated config #307

merged 2 commits into from
May 16, 2019

Conversation

zshi-redhat
Copy link
Contributor

This allows host-device plugin to recognize
Device PCI address passed from Multus.
It is related to the change in host-device which
enables use of device pci address as a config option:
containernetworking/plugins#300

@zshi-redhat
assign device id to pciBusID in delegated config
ec9f6bb 
This allows host-device plugin to recognize
Device PCI address passed from Multus.
It is related to the change in host-device which
enables use of device pci address as a config option:
containernetworking/plugins#300
@zshi-redhat
Copy link
Contributor Author

@s1061123 PTAL

@coveralls
Copy link

coveralls commented Apr 25, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 759

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.5%) to 54.917%
Totals Coverage Status
Change from base Build 755: 3.5%
Covered Lines: 698
Relevant Lines: 1271
💛 - Coveralls

s1061123
s1061123 approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@s1061123 s1061123 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. More than happy if you add test code ;)

@zshi-redhat
Copy link
Contributor Author

Looks good to me. More than happy if you add test code ;)

Thanks Tomo! Added test cases for device ID assignment.

@zshi-redhat
Copy link
Contributor Author

@rkamudhan @ahalim-intel PTAL

@zshi-redhat zshi-redhat mentioned this pull request May 14, 2019
Closed
@dougbtv dougbtv added the release-v3 PRs to make it in release branch label May 16, 2019
@dougbtv dougbtv merged commit 6c23cad into k8snetworkplumbingwg:master May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbtv dougbtv dougbtv approved these changes

@s1061123 s1061123 s1061123 approved these changes

Assignees
No one assigned
Labels
release-v3 PRs to make it in release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zshi-redhat @coveralls @s1061123 @dougbtv