Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vaQuerySurfaceAttributes doesn't support ENC #9

Closed
mypopydev opened this issue Dec 4, 2017 · 5 comments
Closed

vaQuerySurfaceAttributes doesn't support ENC #9

mypopydev opened this issue Dec 4, 2017 · 5 comments

Comments

@mypopydev
Copy link
Contributor

vaQuerySurfaceAttributes support DEC and VPP, but doesn't support ENC

@XinfengZhang
Copy link
Contributor

yes, not implemented for encoder, I wonder whether it is "MUST SUPPORT" , thanks

@mypopydev
Copy link
Contributor Author

If user want to query ENC some information (e,g, input pixel format, max size ... ) , vaQuerySurfaceAttributes is the only interface for this type query, and if ENC change some thing (e,g, maybe support YUV422 in feature, change the max size from 4K to 16K...), no other way to query the ENC, so I think it is "MUST SUPPORT".

@XinfengZhang
Copy link
Contributor

input pixel format can be covered by VAConfigAttribRTFormat, max encode resolution can be supported by VAConfigAttribMaxPictureWidth VAConfigAttribMaxPictureHeight. vaQuerySurfaceAttributes can be used for surface attribute. for example: surface maxium width can be larger than encode ability resolution. they are different things.

@mypopydev
Copy link
Contributor Author

Yes, when encoding, we need to use vaQuerySurfaceAttributes to get the surface constraints, and I don't think VAConfigAttribRTFormat can cover precise pixel format, e,g VA_RT_FORMAT_YUV420 means YUV420P or NV12?

@XinfengZhang
Copy link
Contributor

please help to review #29 , thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants