Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is IQS not building after April 2021 release? Add "iqs" namespace. #48

Open
giangiac opened this issue Apr 15, 2021 · 3 comments
Open
Assignees
Labels
help wanted Extra attention is needed

Comments

@giangiac
Copy link
Contributor

Hi all, I opened this issue as a way to communicate with all users.
In April 2021 we released IQS 2.1.0
This version includes new features and examples (see CHANGELOG for a short list), but also some code cleaning.
As part of adopting good coding practices, we collect all IQS class and methods in namespace "iqs".
If you have problems re-building previous projects, this may be the reason.

The fix is simple. In C++, when declaring a new QubitRegister object just use:
QubitRegister(...) ---> iqs::QubitRegister(...)

@giangiac giangiac self-assigned this Apr 15, 2021
@giangiac giangiac added the help wanted Extra attention is needed label Apr 15, 2021
@mbuchberger1967
Copy link
Contributor

mbuchberger1967 commented Jul 17, 2021

I used the name 'iqs' myself as a sub-namespace in my project's namespace structure.
This can be fixed by using the ::iqs::QubitRegister to access the new top-level namespace 'iqs'.

@giangiac
Copy link
Contributor Author

Is it enough to use ::iqs::QubitRegister in your project's code, or should the leading "::" be used in this repository's (i.e. intel-qs) code too?

@mbuchberger1967
Copy link
Contributor

It is enough to use ::iqs::QubitRegister in my code. Just as a hint for others, if they run into a similar problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants