Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPU-plugin: add cdi support #1827

Merged
merged 2 commits into from
Sep 11, 2024
Merged

GPU-plugin: add cdi support #1827

merged 2 commits into from
Sep 11, 2024

Conversation

tkatila
Copy link
Contributor

@tkatila tkatila commented Sep 3, 2024

This is on top of the generic CDI restructuring: #1810

bart0sh
bart0sh reviewed Sep 3, 2024
View reviewed changes
cmd/fpga_plugin/dfl_test.go Outdated Show resolved Hide resolved
@tkatila tkatila marked this pull request as ready for review September 3, 2024 15:06
@tkatila tkatila force-pushed the gpu-plugin-cdi-support branch from f0ec152 to ec0d19f Compare September 5, 2024 10:44
@tkatila
Copy link
Contributor Author

tkatila commented Sep 6, 2024

@eero-t & @uniemimu can you please review?

(Failed check is due to internal certificate issue, I do not suspect it to be a real problem.)

eero-t
eero-t reviewed Sep 6, 2024
View reviewed changes
Copy link
Contributor

@eero-t eero-t left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not notice any problems (except possibly for "devicee" -> "device"), but unfortunately I didn't have time for proper review, so here are just some superficial comments...

cmd/gpu_plugin/gpu_plugin_test.go Show resolved Hide resolved
cmd/gpu_plugin/README.md Outdated Show resolved Hide resolved
cmd/gpu_plugin/gpu_plugin_test.go Outdated Show resolved Hide resolved
cmd/gpu_plugin/gpu_plugin_test.go Outdated Show resolved Hide resolved
cmd/gpu_plugin/gpu_plugin_test.go Show resolved Hide resolved
@tkatila tkatila force-pushed the gpu-plugin-cdi-support branch 2 times, most recently from d084396 to cfbf82c Compare September 9, 2024 09:13
uniemimu
uniemimu reviewed Sep 9, 2024
View reviewed changes
test/e2e/utils/utils.go Outdated Show resolved Hide resolved
@tkatila tkatila force-pushed the gpu-plugin-cdi-support branch from 9b37ef3 to de89b0f Compare September 9, 2024 13:27
bart0sh
bart0sh reviewed Sep 10, 2024
View reviewed changes
cmd/gpu_plugin/README.md Outdated Show resolved Hide resolved
bart0sh
bart0sh reviewed Sep 10, 2024
View reviewed changes
.golangci.yml Show resolved Hide resolved
bart0sh
bart0sh approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@bart0sh bart0sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tkatila tkatila force-pushed the gpu-plugin-cdi-support branch from 4007a81 to 4be7ab7 Compare September 11, 2024 05:41
@tkatila tkatila force-pushed the gpu-plugin-cdi-support branch from 4be7ab7 to 8dd5b4a Compare September 11, 2024 06:30
@mythi mythi merged commit 539c3e3 into intel:main Sep 11, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eero-t eero-t eero-t left review comments

@bart0sh bart0sh bart0sh approved these changes

@mythi mythi mythi approved these changes

@uniemimu uniemimu uniemimu approved these changes

@kad kad Awaiting requested review from kad kad is a code owner

@ozhuraki ozhuraki Awaiting requested review from ozhuraki ozhuraki is a code owner

@hj-johannes-lee hj-johannes-lee Awaiting requested review from hj-johannes-lee hj-johannes-lee is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tkatila @uniemimu @mythi @eero-t @bart0sh