Restructure CDI use with plugins #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eero-t
reviewed
Aug 19, 2024
It allows the plugins (or their initcontainers) to generate the full spec rather than being limited to a subset (hooks) of the functionality. |
tkatila
force-pushed
the
cdi-make-more-generic
branch
2 times, most recently
from
8ee3530 to
7d333b7
Compare
tkatila
requested review from
mythi,
bart0sh,
hj-johannes-lee,
uniemimu and
kad
as code owners
bart0sh
reviewed
Aug 21, 2024
bart0sh
reviewed
Aug 21, 2024
tkatila
force-pushed
the
cdi-make-more-generic
branch
2 times, most recently
from
975f54d to
8625c5a
Compare
bart0sh
reviewed
Aug 26, 2024
bart0sh
reviewed
Aug 26, 2024
mythi
reviewed
Aug 26, 2024
tkatila
force-pushed
the
cdi-make-more-generic
branch
2 times, most recently
from
9ff8504 to
f950803
Compare
bart0sh
reviewed
Aug 27, 2024
tkatila
force-pushed
the
cdi-make-more-generic
branch
8 times, most recently
from
04c8549 to
51d464b
Compare
|
@bart0sh please review again |
Pass the whole cdi.spec structure to DeviceInfo and use cdiCache for interacting with the CDI files on the host. Signed-off-by: Tuomas Katila <[email protected]>
tkatila
force-pushed
the
cdi-make-more-generic
branch
from
51d464b to
c3a01b9
Compare
mythi
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure CDI use with plugins. Allow passing the whole CDI spec from plugin to server.