-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QAT: make plugin read trimmed heartbeat status #1796
Conversation
@hj-johannes-lee please rebase for the IAA fix. |
Plugin used to consider only the value "-1" but there are some cases when files show "\n" or "\n\x00". This makes plugin to have wrong status of the device. So, trim the value after \n so only numerical value can be read. Signed-off-by: Hyeongju Johannes Lee <[email protected]>
850a12a
to
ea6d52d
Compare
@tkatila done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be simpler just to trim the string: https://pkg.go.dev/strings#TrimSpace ?
it does not give the expected result:
gives:
|
|
|
Plugin used to consider only the value "-1" but there are some cases when files show "\n" or "\n\x00". This makes plugin to have wrong status of the device. So, trim the value after \n so only numerical value can be read.