Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin workflow actions sha's #1741

Merged
merged 1 commit into from
May 28, 2024
Merged

Pin workflow actions sha's #1741

merged 1 commit into from
May 28, 2024

Conversation

tkatila
Copy link
Contributor

@tkatila tkatila commented May 20, 2024

Fix issues generated by the scorecard.

@tkatila tkatila requested review from bart0sh, mythi and kad as code owners May 20, 2024 12:33
@eero-t
Copy link
Contributor

eero-t commented May 20, 2024

I'd also like some documentation on the update process, e.g. how often these SHAs will be updated after this?

I mean, unstable distros (like Debian one) gets updates constantly, even 20.04 LTS tag gets security updates [1] fairly often...

[1] last one seems to have been 19 days ago: https://hub.docker.com/layers/amd64/ubuntu/20.04/images/sha256-cc9cc8169c9517ae035cf293b15f06922cb8c6c864d625a72b7b18667f264b70

@mythi
Copy link
Contributor

mythi commented May 20, 2024

I'd also like some documentation on the update process, e.g. how often these SHAs will be updated after this?

automatically by dependabot using the interval set in this PR.

@tkatila
Copy link
Contributor Author

tkatila commented May 20, 2024

I ran some tests on my personal project: tkatila#9

If one adds full version details in the comment (x.y.z) dependabot will also update the comment.

I haven't tested the dockerfile update. I should test that before this is merged.

@tkatila
Copy link
Contributor Author

tkatila commented May 21, 2024

I haven't tested the dockerfile update. I should test that before this is merged.

Well. It doesn't work. Dependabot scanned a purposefully downgraded Dockerfile and deemed it ok. Looking closer at it, the documentation says that in order for dependabot to work:

In order for Dependabot to fetch Docker metadata, maintainers of Docker images must add the org.opencontainers.image.source label to their Dockerfile, and include the URL of the source repository.

That doesn't seem to be true for ubuntu or debian images:
https://hub.docker.com/layers/library/debian/unstable-slim/images/sha256-93f700ccfb363bf77c05dc71945a6a2a25abf9a1eb502b0afd2168c2eec463bd?context=explore
https://hub.docker.com/layers/library/ubuntu/22.04/images/sha256-2af372c1e2645779643284c7dc38775e3dbbc417b2d784a27c5a9eb784014fb8?context=explore

I'll see if there's some other way to update the sha's.

@tkatila
Copy link
Contributor Author

tkatila commented May 21, 2024

One way to achieve updates for demo SHAs: I wrote a small script that uses frizbee to check for latest versions. That script is then used in a workload that updates the SHAs and creates a pull request:
https://github.com/tkatila/intel-device-plugins-for-kubernetes/actions/runs/9174022590
tkatila#17
https://github.com/tkatila/intel-device-plugins-for-kubernetes/blob/main/.github/workflows/demo-img-update.yaml

Comments?

@mythi
Copy link
Contributor

mythi commented May 22, 2024

My 2 cents is that we could start with the actions pinning only and let the image sha support to evolve a bit (however, it looks the dependabot solution sets a lot of expectations for the image maintainers which may or may not happen anytime soon for the images we depend on).

@tkatila
Copy link
Contributor Author

tkatila commented May 22, 2024

My 2 cents is that we could start with the actions pinning only and let the image sha support to evolve a bit (however, it looks the dependabot solution sets a lot of expectations for the image maintainers which may or may not happen anytime soon for the images we depend on).

Sure. I'll modify this PR to only pin GH actions. We can re-evaluate Dockerfile pinning at a later date.

@tkatila tkatila force-pushed the workflow-pin-to-sha branch from 271f650 to 204bfc0 Compare May 22, 2024 07:02
And update sha's once a week.

Signed-off-by: Tuomas Katila <[email protected]>
@tkatila tkatila force-pushed the workflow-pin-to-sha branch from 204bfc0 to dfa9133 Compare May 28, 2024 09:08
@tkatila tkatila changed the title Pin workflow actions and demo base image versions with sha's Pin workflow actions sha's May 28, 2024
@mythi mythi merged commit beac585 into intel:main May 28, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants