Fix false failures with trivy config scan #1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkatila
requested review from
hj-johannes-lee,
bart0sh,
mythi and
kad
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1652 +/- ##
=======================================
Coverage 51.94% 51.94%
=======================================
Files 42 42
Lines 4911 4911
=======================================
Hits 2551 2551
Misses 2210 2210
Partials 150 150 ☔ View full report in Codecov by Sentry. |
tkatila
force-pushed
the
trivy-config-false-failures
branch
2 times, most recently
from
f43d0a5 to
f477724
Compare
Sadly GH's trivy-action doesn't support the trivyignore.yaml file. The whole detection class needs to be ignored. Include the .yaml file for future use. Signed-off-by: Tuomas Katila <[email protected]>
tkatila
force-pushed
the
trivy-config-false-failures
branch
from
f477724 to
7e8aba1
Compare
mythi
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.