ci: update golangci-lint #1586
Merged
ci: update golangci-lint #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikko Ylinen <[email protected]>
Signed-off-by: Mikko Ylinen <[email protected]>
Signed-off-by: Mikko Ylinen <[email protected]>
Signed-off-by: Mikko Ylinen <[email protected]>
mythi
requested review from
tkatila,
bart0sh,
kad and
uniemimu
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1586 +/- ##
=======================================
Coverage 49.50% 49.50%
=======================================
Files 42 42
Lines 4965 4965
=======================================
Hits 2458 2458
Misses 2363 2363
Partials 144 144
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
eero-t
approved these changes
Nov 6, 2023
| @@ -47,9 +45,9 @@ func GetFPGABitstream(bitstreamDir, region, afu string) (File, error) { | |||
| // Open bitstream file, detecting type based on the filename extension. | |||
| func Open(fname string) (File, error) { | |||
| switch filepath.Ext(fname) { | |||
| case ".gbs": | |||
| case fileExtensionGBS: | |||
There was a problem hiding this comment.
IMHO code would be clearer if this Open() function would be inlined into GetFPGABitstream() loop. That way one could more easily see that loop handles all cases that it ranges through.
There was a problem hiding this comment.
Looks reasonable to me but it could be handled in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.