-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xelink support #1580
xelink support #1580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some stylistic code comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine now, just a small suggestion (which can be ignored) => approved.
@hsyrja golangci-lint-1.55.2 reported couple of code formatting/style issues:
To make sure your PR passes it, you'll probably need to do something like:
Note: those fetch a lot of stuff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linter passed now too (and the rest of the currently running tests cannot fail due to these changes), so this is now ready for merging.
Updated xelink support