Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xelink support #1580

Merged
merged 2 commits into from
Nov 17, 2023
Merged

xelink support #1580

merged 2 commits into from
Nov 17, 2023

Conversation

hsyrja
Copy link
Contributor

@hsyrja hsyrja commented Oct 27, 2023

Updated xelink support

cmd/gpu_fakedev/gpu_fakedev.go Outdated Show resolved Hide resolved
cmd/gpu_fakedev/gpu_fakedev.go Outdated Show resolved Hide resolved
Copy link
Contributor

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some stylistic code comments.

cmd/gpu_fakedev/gpu_fakedev.go Outdated Show resolved Hide resolved
cmd/gpu_fakedev/gpu_fakedev.go Show resolved Hide resolved
cmd/gpu_fakedev/gpu_fakedev.go Outdated Show resolved Hide resolved
cmd/gpu_fakedev/gpu_fakedev.go Outdated Show resolved Hide resolved
eero-t
eero-t previously approved these changes Nov 15, 2023
Copy link
Contributor

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine now, just a small suggestion (which can be ignored) => approved.

cmd/gpu_fakedev/gpu_fakedev.go Outdated Show resolved Hide resolved
eero-t
eero-t previously approved these changes Nov 15, 2023
@eero-t
Copy link
Contributor

eero-t commented Nov 15, 2023

@hsyrja golangci-lint-1.55.2 reported couple of code formatting/style issues:

  Error: Comment should end in a period (godot)
  Error: expressions should not be cuddled with blocks (wsl)

To make sure your PR passes it, you'll probably need to do something like:

make vendor install-tools
make lint

Note: those fetch a lot of stuff. install-tools installs also k8s code generators, not just linter, and lint target complains unless vendored stuff is up to date => You may want just to install golangci-lint manually and give it just gpu_fakedev.go...

Copy link
Contributor

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter passed now too (and the rest of the currently running tests cannot fail due to these changes), so this is now ready for merging.

@tkatila tkatila merged commit 89a0ad9 into intel:main Nov 17, 2023
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants