Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the regular expression of the device type to support sIOV device #1474

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

lzha111
Copy link
Contributor

@lzha111 lzha111 commented Jul 17, 2023

…OV device of QAT

The string of the sIOV device type exceeds the range of [[alnum]], such as: # adf_ctl status
Checking status of all devices.
There is 2 QAT acceleration device(s) in the system:
qat_dev0 - type: vqat-adi, inst_id: 0, node_id: 0, bsf: 0000:00:08.0, #accel: 1 #engines: 1 state: up
qat_dev1 - type: vqat-adi, inst_id: 1, node_id: 0, bsf: 0000:00:09.0, #accel: 1 #engines: 1 state: up

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2023

Codecov Report

Merging #1474 (5fb2736) into main (432741e) will not change coverage.
The diff coverage is n/a.

❗ Current head 5fb2736 differs from pull request most recent head 8fbf934. Consider uploading reports for the commit 8fbf934 to get more accurate results

@@           Coverage Diff           @@
##             main    #1474   +/-   ##
=======================================
  Coverage   50.04%   50.04%           
=======================================
  Files          43       43           
  Lines        4884     4884           
=======================================
  Hits         2444     2444           
  Misses       2301     2301           
  Partials      139      139           
Impacted Files Coverage Δ
cmd/qat_plugin/kerneldrv/kerneldrv.go 75.84% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mythi
Copy link
Contributor

mythi commented Jul 20, 2023

@lzha111 looks OK to me but can you rebase so we get fresh CI results

@lzha111
Copy link
Contributor Author

lzha111 commented Jul 20, 2023

@lzha111 looks OK to me but can you rebase so we get fresh CI results

sorry, I did not know what need I do.

@lzha111
Copy link
Contributor Author

lzha111 commented Jul 24, 2023

Hi, it seems that all checks have passed, anything else to do?

@mythi
Copy link
Contributor

mythi commented Jul 24, 2023

Hi, it seems that all checks have passed, anything else to do?

I was hoping to see a rebase:

git fetch https://github.com/intel/intel-device-plugins-for-kubernetes.git
git rebase FETCH_HEAD
git push -f origin HEAD

…OV device of QAT

The string of the sIOV device type exceeds the range of [[alnum]], such as:
# adf_ctl status
Checking status of all devices.
There is 2 QAT acceleration device(s) in the system:
 qat_dev0 - type: vqat-adi,  inst_id: 0,  node_id: 0,  bsf: 0000:00:08.0,  #accel: 1 #engines: 1 state: up
 qat_dev1 - type: vqat-adi,  inst_id: 1,  node_id: 0,  bsf: 0000:00:09.0,  #accel: 1 #engines: 1 state: up
@lzha111
Copy link
Contributor Author

lzha111 commented Jul 24, 2023

Hi, it seems that all checks have passed, anything else to do?

I was hoping to see a rebase:

git fetch https://github.com/intel/intel-device-plugins-for-kubernetes.git
git rebase FETCH_HEAD
git push -f origin HEAD

OK, got it, thank you! It has been completed.

@mythi mythi merged commit e57723c into intel:main Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants